add override capabilities to repeated capabilities documentation - #2183

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.10%. Comparing base (1e272b6) to head (26b3c1b).

@@           Coverage Diff           @@
##           master    #2183   +/-   ##
=======================================
  Coverage   88.09%   88.10%           
=======================================
  Files          88       88           
  Lines       22756    22765    +9     
=======================================
+ Hits        20047    20057   +10     
+ Misses       2709     2708    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Why are you changing the file modes of our metadata files?

Note: if you pull the latest changes, the system tests will pass.
Not really a requirement for this change, but the PR Checks would look better.

Why are you changing the file modes of our metadata files?

I did not explicitly touch those files, doing tox -e codegen touched those files, and I just committed.
Removed the changed to file mode in 92b5d19

Note: if you pull the latest changes, the system tests will pass. Not really a requirement for this change, but the PR Checks would look better.

git pull origin says I am up to date with origin. Still one failing change that does not seem correlated to this change

Note: if you pull the latest changes, the system tests will pass. Not really a requirement for this change, but the PR Checks would look better.

git pull origin says I am up to date with origin. Still one failing change that does not seem correlated to this change

Yeah, any system test failures are unrelated to your changes. You haven't touched the API or the System Tests.

"overwrite" should be "override" (nim-python terminology)

You are missing a NI-FAKE example

"overwrite" should be "override" (nim-python terminology)

Hopefully changed all instances of "overwrite" to "override"

You are missing a NI-FAKE example

Added unit tests in test_rep_caps_template.py

Your changes to metadata_add_all.py are causing related unit tests to fail.

Your changes to metadata_add_all.py are causing related unit tests to fail.

Should have fixed failures with Travic CI

Why are you making a functional change?
I thought we talked about this and determined that chained rep caps already provided the necessary functionality.

You should pull upstream/master.
nirfsa has documentation that isn't present in your branch, so you may introducing changes to it that we can't see.

If you see any changes in the existing rep_caps.rst, that's probably not a good sign.
The goal here is to add new support without affecting existing documentation, right?

If you see any changes in the existing rep_caps.rst, that's probably not a good sign. The goal here is to add new support without affecting existing documentation, right?

Changed to remove all changes to the generated .rst files

You should pull upstream/master. nirfsa has documentation that isn't present in your branch, so you may introducing changes to it that we can't see.

Should be up to date from main, pending pipeline tests

This is okay, but some of the template code feels a bit brittle.

Any recommendations for making it less brittle? or should I just push in the PR now?